fix(ci): deploy only apps whose build actually succeeded

When an app's typecheck failed, its build job was SKIPPED — which the
deploy condition tolerates (so other apps still ship) — but the deploy
script keyed on the change flags alone and pinned the never-built image
tag, ImagePullBackOff'ing the app (happened to portal on f6bac10).
Deployable now means changed AND build result == success; otherwise the
app keeps its live image, including in the manifest-apply path.

.gitea/workflows/ci.yml

@@ -239,6 +239,13 @@ jobs:
       - name: Deploy to k3s
         env:
           KUBECONFIG_B64: ${{ secrets.KUBECONFIG_B64 }}
+          # Build results, not just change flags: an app whose typecheck/test
+          # failed has result=skipped on its build — its image for this SHA
+          # does NOT exist, and pinning it would ImagePullBackOff the app.
+          BUILT_PORTAL: ${{ needs.build_portal.result }}
+          BUILT_BOOKING: ${{ needs.build_booking.result }}
+          BUILT_OPERATOR: ${{ needs.build_operator.result }}
+          BUILT_PLATFORM_API: ${{ needs.build_platform_api.result }}
         run: |
           export KUBECONFIG=/tmp/kubeconfig
           echo "$KUBECONFIG_B64" | base64 -d > "$KUBECONFIG"
@@ -250,6 +257,14 @@ jobs:
             [operator]=${{ needs.changes.outputs.operator }}
             [platform-api]=${{ needs.changes.outputs.platform_api }}
           )
+          declare -A BUILT=(
+            [portal]=$BUILT_PORTAL
+            [booking]=$BUILT_BOOKING
+            [operator]=$BUILT_OPERATOR
+            [platform-api]=$BUILT_PLATFORM_API
+          )
+          # Deployable = changed AND its image was actually built this run.
+          deployable() { [ "${CHANGED[$1]}" = "true" ] && [ "${BUILT[$1]}" = "success" ]; }
           ROLL=""
           if [ "${{ needs.changes.outputs.infra }}" = "true" ]; then
             # Manifest change: apply the whole kustomization, but pin every
@@ -257,7 +272,7 @@ jobs:
             # rebuilt) so the apply never resets anything to :latest.
             cd infrastructure/production/fleet/apps
             for app in portal booking platform-api operator; do
-              if [ "${CHANGED[$app]}" = "true" ]; then
+              if deployable "$app"; then
                 IMG="$REG/$app:$SHA"
               else
                 IMG=$(kubectl -n dezky-apps get deploy "$app" -o jsonpath='{.spec.template.spec.containers[0].image}' 2>/dev/null || echo "$REG/$app:latest")
@@ -269,7 +284,7 @@ jobs:
           else
             # App-only change: roll just the changed apps; nothing else moves.
             for app in portal booking platform-api operator; do
-              if [ "${CHANGED[$app]}" = "true" ]; then
+              if deployable "$app"; then
                 kubectl -n dezky-apps set image "deploy/$app" "$app=$REG/$app:$SHA"
                 ROLL="$ROLL $app"
               fi